Configure browsertrix proxies #1847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shrinks99
changed the title
vnznznz
force-pushed
the
configure-socks-proxies
branch
from
a03ac85
to
cf38412
Compare
vnznznz
force-pushed
the
configure-socks-proxies
branch
from
cf38412
to
fca5886
Compare
… just use proxies just pass proxyId to CrawlJob, lookup in operator share single secret for all proxy configs, containg private keys and public host keys use single 'auth' field for 'user@host[:port]'
ikreymer
force-pushed
the
configure-socks-proxies
branch
from
2b435c6
to
80542df
Compare
secrets: map /etc/passwd and /etc/group to ensure user/group are defined for ssh
pass proxy as ssh://<auth> instead of separate --sshProxyLogin flag
require ssh_private_key and ssh_host_public_key for ssh proxies only support description in frontend support 'default_proxy' which sets default proxy if none is specified
display 'Using Proxy' on profile selector, if proxyId is set
vnznznz
commented
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1354
Current state of my socks proxy configuration work.
Done:
browsertrix-proxy, currently just a container foropenssh-clientbut could used to facilitate more proxy connections in the futurecrawler_socks_proxy_servershelm config setting to set a list ssh servers that can be used to create a socks proxy connectionTodos
crawler_socks_proxy_serverorcrawlerSocksProxyServerwhich can either mean theidof the server or the full object or a subset without the sensitive data.browsertrix-crawler, it broke with the removal of pywb, see proxy: support setting proxy via --proxyServer, PROXY_SERVER env var or PROXY_HOST + PROXY_PORT env vars browsertrix-crawler#589Needed for local testing: